Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: check NotNullFlag of columns when simplifying binary operations (#24049) #24063

Merged
merged 6 commits into from
Apr 16, 2021
Merged

expression: check NotNullFlag of columns when simplifying binary operations (#24049) #24063

merged 6 commits into from
Apr 16, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 15, 2021 •
edited
Loading

cherry-pick #24049 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24063

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/24063:release-5.0-75a031af4ad3

What problem does this PR solve?

Issue Number: close #23891

Problem Summary:

Wrong result of queries.

What is changed and how it works?

What's Changed:

Check NotNullFlag in refineArgs before saying that the result of the expression is exceptional.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Fix wrong query result when column contains null values

@ti-srebot ti-srebot requested review from a team as code owners April 15, 2021 15:04
@ti-srebot ti-srebot requested review from wshwsh12 and winoros and removed request for a team April 15, 2021 15:04
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Apr 15, 2021
Merged
@ti-srebot ti-srebot added component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.0-cherry-pick type/bugfix This PR fixes a bug. labels Apr 15, 2021
@ti-srebot ti-srebot added this to the v5.0.0 ga milestone Apr 15, 2021
@ti-srebot
Copy link
Contributor Author

@eurekaka you're already a collaborator in bot's repo.

@eurekaka eurekaka force-pushed the release-5.0-75a031af4ad3 branch from c18c506 to 9f573ad Compare April 16, 2021 03:17
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2021
time-and-fate
time-and-fate approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 16, 2021
@eurekaka
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 54267568e928d164fddc9a7a39e7149cdf4b9284

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 16, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2021
@eurekaka eurekaka force-pushed the release-5.0-75a031af4ad3 branch from 0c7a046 to 2bd8b50 Compare April 16, 2021 07:50
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2021
@eurekaka
Copy link
Contributor

/merge

@eurekaka
Copy link
Contributor

/run-integration-copr-test

@eurekaka
Copy link
Contributor

/merge

@zimulala
Copy link
Contributor

/run-common-test

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 83d786b into pingcap:release-5.0 Apr 16, 2021
@eurekaka eurekaka deleted the release-5.0-75a031af4ad3 branch April 19, 2021 03:22
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.0 ga, v5.0.1 Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 qw4990 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@winoros winoros Awaiting requested review from winoros

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@eurekaka eurekaka

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.1
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @eurekaka @zimulala @qw4990 @time-and-fate @zhouqiang-cl